Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index of bnd is lost when reading an existing model #115

Open
3 tasks
DirkEilander opened this issue Aug 1, 2023 · 1 comment
Open
3 tasks

index of bnd is lost when reading an existing model #115

DirkEilander opened this issue Aug 1, 2023 · 1 comment
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@DirkEilander
Copy link
Contributor

When creating a model the index column of your locations from setup_waterlevel_forcing is used. However after reading this model again the index (and all other properties) are lost, These properties are not saved in the sfincs.bnd file but can be read from the bnd.geojson file. The dimension order of the forcing has also changed.

TODO:

  • use the properties from the bnd.geojson file to update the index of bzs forcing in read_forcing
  • transpose the dimensions to have time on the first dimension in read_forcing
  • check if the same is true for src points
@roeldegoede
Copy link
Collaborator

Good observation! This indeed links to one of the discussion points of #114, where we also lose the original indices when setting up observation lines. Same holds for setup_observation_points. Let's try to fix those all at once.

@roeldegoede roeldegoede added this to the Release DSD milestone Sep 13, 2023
@roeldegoede roeldegoede added the Enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants