From ced3c7e524a20f6ccd4f6244205b7e1eb2eb361d Mon Sep 17 00:00:00 2001 From: Mabel Zhang Date: Thu, 14 May 2020 19:55:01 -0400 Subject: [PATCH] Disable play_filters_by_topic test (#410) * disable play_filters_by_topic Signed-off-by: Mabel Zhang * Add ticket to disabled test Signed-off-by: Mabel Zhang Co-authored-by: Tully Foote Co-authored-by: Tully Foote --- .../test/rosbag2_tests/test_rosbag2_play_end_to_end.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rosbag2_tests/test/rosbag2_tests/test_rosbag2_play_end_to_end.cpp b/rosbag2_tests/test/rosbag2_tests/test_rosbag2_play_end_to_end.cpp index dade2eb135..f1f8de1383 100644 --- a/rosbag2_tests/test/rosbag2_tests/test_rosbag2_play_end_to_end.cpp +++ b/rosbag2_tests/test/rosbag2_tests/test_rosbag2_play_end_to_end.cpp @@ -120,7 +120,8 @@ TEST_F(PlayEndToEndTestFixture, play_fails_gracefully_if_needed_coverter_plugin_ error_output, HasSubstr("Requested converter for format 'wrong_format' does not exist")); } -#ifndef _WIN32 +/* +todo(tfoote) Disabling failing test. Ticketed to follow up at: https://github.com/ros2/rosbag2/issues/408 TEST_F(PlayEndToEndTestFixture, play_filters_by_topic) { // Due to a problem related to the subscriber, we play many (3) messages but make the subscriber // node spin only until 2 have arrived. Hence the 2 as `launch_subscriber()` argument. @@ -209,4 +210,4 @@ TEST_F(PlayEndToEndTestFixture, play_filters_by_topic) { EXPECT_THAT(primitive_messages, SizeIs(Ge(0u))); EXPECT_THAT(array_messages, SizeIs(Ge(0u))); } -#endif +*/