Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add windows-dark theme #299

Merged
merged 4 commits into from Aug 9, 2022
Merged

feat: Add windows-dark theme #299

merged 4 commits into from Aug 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022

Description

Added new windows-dark theme

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

With border

image

Without border

image

DenverCoder1
DenverCoder1 reviewed Aug 8, 2022
View reviewed changes
docs/themes.md Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Aug 9, 2022

Okay.

@DenverCoder1
style: Format with Prettier
6ccef46 
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
DenverCoder1
DenverCoder1 approved these changes Aug 9, 2022
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 715563d into DenverCoder1:main Aug 9, 2022
@ghost ghost deleted the windows-dark branch August 9, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DenverCoder1