Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sea-dark theme #307

Merged
merged 6 commits into from Aug 12, 2022
Merged

feat: Add sea-dark theme #307

merged 6 commits into from Aug 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2022

Description

Added new sea-dark theme.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

@DenverCoder1
Copy link
Owner

I kind of feel the white part seems out of place and would maybe be better with a dark color such as a dark blue or black.

Maybe something like #00546F would look good for the stroke?

image

Again, up to you. Let me know what you think.

@ghost
Copy link
Author

ghost commented Aug 12, 2022

Okay.

@ghost
Copy link
Author

ghost commented Aug 12, 2022

Ready.

@ghost
Copy link
Author

ghost commented Aug 12, 2022

I don't know why, but after I updated the branch to DenverCoder1/github-readme-streak-stats:main, the Prettier task failed in both pull requests.

@DenverCoder1 DenverCoder1 merged commit 0689ca9 into DenverCoder1:main Aug 12, 2022
@DenverCoder1
Copy link
Owner

Thanks!

@ghost ghost deleted the sea-dark branch August 13, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant