Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets can lose their scroll bar (Filters Help) #10346

Open
robojumper opened this issue Apr 19, 2024 · 20 comments · May be fixed by #10465
Open

Sheets can lose their scroll bar (Filters Help) #10346

robojumper opened this issue Apr 19, 2024 · 20 comments · May be fixed by #10465
Assignees
Labels
Bug CSS/design styling & layout issues

Comments

@robojumper
Copy link
Member

DIM Version

Version 8.16.0.3284 (beta), built on 4/16/2024, 10:58:13 PM

Browser Details

Edge 123, Firefox 125

OS Details

Windows 10

Describe the bug

  • Open the Filters Help sheet from the search bar
  • As expected, the sheet has a scroll bar that allows scrolling to view all filters
  • Type 123 in the sheet search bar, which doesn't match any filters
  • Scroll bar disappears
  • Clear sheet search bar contents
  • Unexpectedly, scroll bar is still hidden, which prevents scrolling to view filters

Logs

None relevant
@robojumper robojumper added the Bug label Apr 19, 2024
@bhollis
Copy link
Contributor

bhollis commented Apr 25, 2024

Related to #9240, caused by sheets recalculating their maximum height incorrectly

@ryan-rushton
Copy link
Contributor

ryan-rushton commented May 4, 2024

Is the issue that the sheet is calculating the max height but loading contents is async? If that is the case we need to provide the contents a callback it can call when its contents have loaded correctly.

Edit: The async nature is due to react suspense, which react handles correctly if we put the sheet behind the suspense boundary too.

@ryan-rushton
Copy link
Contributor

@robojumper can you test and close for me? It should be live on beta now.

@robojumper
Copy link
Member Author

I'm still seeing this with given repro steps in Version 8.19.0.3324 (beta)

@ryan-rushton
Copy link
Contributor

Hmmm ok, it must be something else. It fixed the other issue Ben linked. I will have a look.

@ryan-rushton
Copy link
Contributor

@robojumper I cannot reproduce this on chrome or firefox (125 video attached). Could this be a windows thing?

Screen.Recording.2024-05-09.at.6.44.47.PM.mov

@robojumper
Copy link
Member Author

This affects the desktop layout for me. You might be able to reproduce it with the dev tools mobile emulation turned off?

@ryan-rushton
Copy link
Contributor

I tried both, which are both fine for me. I will get a vid of firefox there too

@ryan-rushton
Copy link
Contributor

ryan-rushton commented May 9, 2024

Screen.Recording.2024-05-09.at.6.56.26.PM.mov
Screenshot 2024-05-09 at 6 58 08 PM

@ryan-rushton
Copy link
Contributor

I'll try reproduce this on my gaming PC when I get a chance and remember to.

@ryan-rushton
Copy link
Contributor

Just tried this again on Firefox 126 and 125.03 on windows and I don't see the issue. @robojumper do you have any non default settings enabled in firefox?

@robojumper
Copy link
Member Author

My Firefox is pretty customized but it also happens in Edge
GIF 19 05 2024 16-12-45

@ryan-rushton
Copy link
Contributor

Ok, I will try with that next.

@bhollis
Copy link
Contributor

bhollis commented May 24, 2024

I wasn't able to repro on Chrome or Firefox for macOS.

@ryan-rushton
Copy link
Contributor

Yeah I have tried a few combo's and can't repro. I need to do the edge one but I think this is due to something non-default in robo's settings.

@delphiactual
Copy link
Contributor

as soon as i type the d in asd i lose the scroll bar on chrome (windows)

@ryan-rushton
Copy link
Contributor

And to be clear @delphiactual it doesn't come back once deleting everything?

Also, what version of windows? I am on 11 and note that robo is on 10. So if you are on 10 maybe its a 10 thing

@delphiactual
Copy link
Contributor

i am on win 11, and it does not come back

@ryan-rushton ryan-rushton linked a pull request May 26, 2024 that will close this issue
@ryan-rushton
Copy link
Contributor

ryan-rushton commented May 26, 2024

Managed to reproduce on chrome (I swear I checked that initially). PTAL at the fix if you get a chance.

@ryan-rushton
Copy link
Contributor

This also seems related to #9886 potentially? There seems to be some weird behaviour with this useResizerObserver hook

@bhollis bhollis added the CSS/design styling & layout issues label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CSS/design styling & layout issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants