Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Mountaintop (Probably other weapons too) don't get gold border when T3 enhanced on DIM #10522

Closed
Chrishaun-Easter opened this issue Jun 10, 2024 · 6 comments
Assignees

Comments

@Chrishaun-Easter
Copy link

DIM Version

8.23.0 (2024-06-09)

Browser Details

Firefox 126.0.1 (64-bit)

OS Details

Windows 11

Describe the bug

All shiny brave weapons and new (as in pale heart and echoes weapons) weapons would have golden borders in game but wouldn't in DIM.

The new DIM version (8.23.0) fixed this... Except for The Mountaintop, its still showing without a gold border.

All my other shiny brave weapons and pale heart/echoes weapons show with a gold border.

I think its because my mountaintop has a blast radius masterwork while already being at 100 blast radius, so DIM doesn't think it has a masterwork and doesn't make it gold???

Screenshot 2024-06-10 112243

Logs

Some cookies are misusing the recommended “SameSite“ attribute 12
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
Some cookies are misusing the recommended “SameSite“ attribute 127
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
SessionStore: Discarding window with 0 saveable tabs and 0 closed tabs 3 SessionStore.sys.mjs:2296:19
Some cookies are misusing the recommended “SameSite“ attribute 22
Some cookies are misusing the recommended “SameSite“ attribute 80
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
Content-Security-Policy warnings 2
Some cookies are misusing the recommended “SameSite“ attribute 38
Some cookies are misusing the recommended “SameSite“ attribute 22
Some cookies are misusing the recommended “SameSite“ attribute 39
Content-Security-Policy warnings 2
Content-Security-Policy warnings 2
Content-Security-Policy warnings 2
Some cookies are misusing the recommended “SameSite“ attribute 12
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
Content-Security-Policy warnings 2
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
HTTPS-Only Mode: Not upgrading insecure request “http://ocsp.sectigo.com/” because it is exempt.

IndexedDB UnknownErr: ActorsParent.cpp:9498
IndexedDB UnknownErr: ActorsParent.cpp:17284
IndexedDB UnknownErr: ActorsParent.cpp:10021 3
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
HTTPS-Only Mode: Not upgrading insecure request “http://r3.o.lencr.org/” because it is exempt.
5
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
buildList failed:  NS_ERROR_UNEXPECTED: WindowsJumpLists.sys.mjs:281:15
HTTPS-Only Mode: Not upgrading insecure request “http://ocsp.r2m01.amazontrust.com/” because it is exempt.

this.window.gBrowserInit is undefined ext-browser.js:1118:9
this.window.gBrowserInit is undefined ext-browser.js:1118:9
NotFoundError: No such JSProcessActor 'BrowserToolboxDevToolsProcess' 6
stylesheets: fetch from cache returned non-css content-type application/x-unknown-content-type for moz-extension://7b14b9d3-cecc-4ff7-a6f6-12db2b6e3121/experiment.css, trying without cache. stylesheet-utils.js:110:15
@bhollis
Copy link
Contributor

bhollis commented Jun 10, 2024

Can you provide a screenshot of this weapon in game? Enhancement is pretty new.

@Chrishaun-Easter
Copy link
Author

@bhollis

Both Enhanced Weapons:
tiger_release_final_20240610_112925-min

Mountaintop (Bugged)
338265942-ef0b4ec4-b057-41ff-b6a1-7abf95ff6453
tiger_release_final_20240610_112909-min

Edge Transit (Working)
Screenshot 2024-06-10 113118
tiger_release_final_20240610_113151-min

@delphiactual
Copy link
Contributor

This is probably a bug due to the way perks are showing in the API currently...

@robojumper
Copy link
Member

This should be fixed now that the API is corrected? @Chrishaun-Easter can you let us know if it's working correctly for you now?

@nev-r
Copy link
Member

nev-r commented Jun 15, 2024

image
needs updating, enhanced mountaintop is failing at

const containsEnhancedIntrinsic = createdItem.sockets.allSockets.some(
  (s) => s.plugged && enhancedIntrinsics.has(s.plugged.plugDef.hash),
);

pretty sure this is a blast radius one

@Chrishaun-Easter
Copy link
Author

This should be fixed now that the API is corrected? @Chrishaun-Easter can you let us know if it's working correctly for you now?

Yes it is fixed!

Screenshot_20240616_211046_Chrome

@bhollis bhollis closed this as completed Jun 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants