-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New filter is:uncollected #10404
Comments
https://pr.dim.gg/10584/ has a version of this. It's a bit weird, since some items don't show as collected for some reason... |
@philkernick did you have a chance to try this out? |
I can see it's been implemented as is:collected. Which means to find the uncollected, I need -is:collected. The screenshots below have -is:collected applied. Mostly it seems to work as expected, but I note the following minor issues. For the craftable exotic mission catalysts they still show up as uncollected, but if I click into any of them they say unlocked in collections. Emotes and ghost projects are not consistent. All of the ones that are not shaded should not be shown as I have them. Universal ornaments are also not consistent. The blue ticked ones are unlocked in collections, so shouldn't be showing here. |
Yeah, this is only implementing the same check that vendors uses, in the spirit of "I'm proposing this exact functionality be exposed as a filter is:uncollected". It doesn't have any extra logic to handle all the other special cases in collections. |
Since there hasn't been any other interest, and the definition of "collected" is so difficult, it's not worth it. |
Proposed change
The vendor page has a checkbox named "only show uncollected items". I'm proposing this exact functionality be exposed as a filter is:uncollected
Other optional names for the opposite sense of the same filter is:collected is:incollection
How does this fit into your workflow?
The real use for this filter is on the records page. I want to determine which weapons I have never acquired.
I want to find the weapons highlighted below.
Optionally, if not a filter, then the same checkbox from the vendors page could be added to the records page.
The text was updated successfully, but these errors were encountered: