Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New filter is:uncollected #10404

Closed
philkernick opened this issue May 10, 2024 · 5 comments
Closed

New filter is:uncollected #10404

philkernick opened this issue May 10, 2024 · 5 comments

Comments

@philkernick
Copy link

philkernick commented May 10, 2024

Proposed change

The vendor page has a checkbox named "only show uncollected items". I'm proposing this exact functionality be exposed as a filter is:uncollected

Other optional names for the opposite sense of the same filter is:collected is:incollection

How does this fit into your workflow?

The real use for this filter is on the records page. I want to determine which weapons I have never acquired.

I want to find the weapons highlighted below.

image

Optionally, if not a filter, then the same checkbox from the vendors page could be added to the records page.

@bhollis
Copy link
Contributor

bhollis commented Jun 20, 2024

https://pr.dim.gg/10584/ has a version of this. It's a bit weird, since some items don't show as collected for some reason...

@bhollis
Copy link
Contributor

bhollis commented Jul 17, 2024

@philkernick did you have a chance to try this out?

@philkernick
Copy link
Author

I can see it's been implemented as is:collected. Which means to find the uncollected, I need -is:collected. The screenshots below have -is:collected applied.

Mostly it seems to work as expected, but I note the following minor issues.

For the craftable exotic mission catalysts they still show up as uncollected, but if I click into any of them they say unlocked in collections.

image

Emotes and ghost projects are not consistent. All of the ones that are not shaded should not be shown as I have them.

image

image

Universal ornaments are also not consistent.

image

The blue ticked ones are unlocked in collections, so shouldn't be showing here.

@bhollis
Copy link
Contributor

bhollis commented Jul 17, 2024

Yeah, this is only implementing the same check that vendors uses, in the spirit of "I'm proposing this exact functionality be exposed as a filter is:uncollected". It doesn't have any extra logic to handle all the other special cases in collections.

@bhollis
Copy link
Contributor

bhollis commented Aug 31, 2024

Since there hasn't been any other interest, and the definition of "collected" is so difficult, it's not worth it.

@bhollis bhollis closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants