Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase/remove max note length #10636

Closed
Revadike opened this issue Jul 6, 2024 · 3 comments · Fixed by #10720
Closed

Increase/remove max note length #10636

Revadike opened this issue Jul 6, 2024 · 3 comments · Fixed by #10720

Comments

@Revadike
Copy link
Contributor

Revadike commented Jul 6, 2024

Proposed change

Increase/remove max note length

How does this fit into your workflow?

For months now, I have been running a script that removes the maxlength attribute from notes, because I do not have enough room to always describe all rolls I want for guns. All this time I have not run into any issues. So, it would be nice to have this change natively added to DIM.

@bhollis
Copy link
Contributor

bhollis commented Jul 8, 2024

I will update it to a max length of 1024 characters, which is the most the backend will accept.

@bhollis
Copy link
Contributor

bhollis commented Jul 8, 2024

That said - if you would like to describe the rolls you want for guns, I'd suggest using a wish list.

@Revadike
Copy link
Contributor Author

Revadike commented Sep 6, 2024

Thanks!

That said - if you would like to describe the rolls you want for guns, I'd suggest using a wish list.

Wishlists seem terribly inconvenient to maintain. They should be better integrated, as opposed to requiring external tools. Allow us to select the preferred perks directly on the weapon, when inspecting them. It would also be nice to define multiple god roll combo's or variations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants