Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basedpyright should also do syntax highlighting #689

Open
DetachHead opened this issue Sep 22, 2024 · 2 comments
Open

basedpyright should also do syntax highlighting #689

DetachHead opened this issue Sep 22, 2024 · 2 comments

Comments

@DetachHead
Copy link
Owner

DetachHead commented Sep 22, 2024

currently the semantic highlighting assumes your editor already does the basic syntax highlighting, but vscode's sucks because it uses an abandoned 3rd party package (microsoft/pylance-release#5824)

this would address all issues labelled with vscode syntax highlighting issues with vscode's native python syntax highlighting rather than an issue with our LSP , along with this neovim syntax highlighting issue with match statements that was raised in the discord:

image

probably also need to figure out #147, as there are two different colours used (in vscode at least) for keywords and i'm not sure what the distinction between them is supposed to be

@shoucandanghehe
Copy link

shoucandanghehe commented Oct 12, 2024

I'm not sure if this is the right place, but match also has problems with syntax highlighting in vscode
image

UPDATE: It seems to be a problem with the MagicPython plugin, disabled and back to normal, but it is normal to use Pylance and MagicPython at the same time.

@DetachHead
Copy link
Owner Author

magicpython is bundled with vscode and also hasn't been updated in ages (see microsoft/pylance-release#5824). match statements look fine for me so i assume the extension you're using has gone even longer without an update than that version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants