Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ability to specify language through Directive #121

Open
1 task done
dwfe opened this issue Aug 26, 2018 · 1 comment
Open
1 task done

[Feature] Ability to specify language through Directive #121

dwfe opened this issue Aug 26, 2018 · 1 comment

Comments

@dwfe
Copy link

dwfe commented Aug 26, 2018

Summary

I'm submitting a:

  • feature request

Description

Now we can specify the language in the module.

But in case the user can change the language via the interface, then I have no way to pass the language changes to the re-captcha component.

Could you expand Input Options with a Directive, that would allow you to pass the language to the re-captcha component.

Lib versions:

  • ng-recaptcha: 4.0.0-beta.1
  • Angular: 6.1.4
  • Typescript: 2.7.2
@DethAriel
Copy link
Owner

Hello @dwfe ! Thx for reaching out.

There have been multiple attempts to do that in the past, both from myself as well as from contributors, and they had various downsides:

  • relying on solely the public reCAPTCHA api resulted in unstable behavior after language has been changed
  • relying on internal reCAPTCHA api was stable, but did not guarantee that the solution will always work - we don't have full control of internals and would be at the mercy of reCAPTCHA core team

I agree that it would have been a great feature.

There are no plans to get back to that for now, but I'll leave the issue open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants