Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature]: Modal 模态弹窗添加全屏功能 #319

Closed
xuxzh opened this issue Jun 21, 2023 · 3 comments · Fixed by #326
Closed

✨ [Feature]: Modal 模态弹窗添加全屏功能 #319

xuxzh opened this issue Jun 21, 2023 · 3 comments · Fixed by #326

Comments

@xuxzh
Copy link
Contributor

xuxzh commented Jun 21, 2023

What problem does this feature solve

之前在ng-devui v9版本我们自己实现了模态框的全屏功能，如下图所示。请问在最新版的v15版本上有添加全屏功能的计划吗？或者我自己实现下，然后提个pr可以吗？
image

image

What does the proposed API look like

image
image
image
@Simplelegant
Copy link
Collaborator

欢迎提PR参与贡献~

@xuxzh
Copy link
Contributor Author

xuxzh commented Jul 17, 2023

已提PR，麻烦看下是否可行：#320

@Simplelegant
Copy link
Collaborator

已提PR，麻烦看下是否可行：#320

感谢贡献，我们看下代码~

@wangyaju wangyaju mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
2023 Idea Square
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): release 16.1.0 DevCloudFE/ng-devui
2 participants
@Simplelegant @xuxzh