Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom reporter: Create option to pass in namespaced custom reporter path #4692

Closed
mcbriarty opened this issue Jan 23, 2020 · 4 comments
Closed
Labels
AREA: server STATE: Stale An outdated issue that will be automatically closed by the Stale bot. SYSTEM: reporting TYPE: enhancement The accepted proposal for future implementation.
Milestone

Comments

@mcbriarty
Copy link

What is your Test Scenario?

Currently, the path to the custom reporter must be at the node_modules root level. A reporter that I created lives in a namespaced location so I need to add a postinstall action that moves the folder from the namespace to the root level. It would be great if we could avoid the postinstall command.

What are you suggesting?

Pass in an optional path to the reporter so we can keep our custom reporter in our namespace:

node_modules/@someNamespace/testcafe-reporter-custom

What alternatives have you considered?

n/a

Additional context

Reference to the currently hardcoded path:

return require('testcafe-reporter-' + reporterName);

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 23, 2020
@LavrovArtem
Copy link
Contributor

Thank you for the good suggestion. We will help you if he wants to do PR. In the meantime, you can install your package without scopes using the next npm 6+ feature:

npm i --save testcafe-reporter-custom@npm:@someNamespace/testcafe-reporter-custom

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 27, 2020
@LavrovArtem LavrovArtem added SYSTEM: reporting TYPE: enhancement The accepted proposal for future implementation. labels Jan 27, 2020
@LavrovArtem LavrovArtem added this to the Planned milestone Jan 27, 2020
@mcbriarty
Copy link
Author

Thanks! I hadn't known about the alternate install method introduced in npm 6 and it works like a charm.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Jan 29, 2020
@AlexSkorkin AlexSkorkin removed the STATE: Need response An issue that requires a response or attention from the team. label Jan 30, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this issue in the future. If it still affects you or you have any additional information regarding it, please leave a comment and we will keep it open.

@github-actions github-actions bot added the STATE: Stale An outdated issue that will be automatically closed by the Stale bot. label Jan 30, 2021
@github-actions
Copy link

We're closing this issue after a prolonged period of inactivity. If it still affects you, please add a comment to this issue with up-to-date information. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AREA: server STATE: Stale An outdated issue that will be automatically closed by the Stale bot. SYSTEM: reporting TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Development

No branches or pull requests

4 participants