From 6104dec0d62ed615840890d2bf4b54da999a64b0 Mon Sep 17 00:00:00 2001 From: Amrest Chinkamol Date: Fri, 9 Aug 2024 21:38:17 +0700 Subject: [PATCH] fix: Fix `pr_number` being null when triggered by `issue_comment` (#272) * fix: Fix `pr_number` when triggered by `issue_comment` * default to `0` if `context.issue.number` is absent Big thanks to @p4perf4ce for contributing. --------- Co-authored-by: Rishav Dhar <19497993+RDhar@users.noreply.github.com> --- action.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/action.js b/action.js index 88921eb6..f7112c78 100644 --- a/action.js +++ b/action.js @@ -5,10 +5,8 @@ module.exports = async ({ context, core, exec, github }) => { const fmt_result_limit = 6e3; // Get PR number from event trigger for unique identifier. - let pr_number = 0; - if (context.eventName === "pull_request") { - pr_number = context.issue.number; - } else if (context.eventName === "push") { + let pr_number; + if (context.eventName === "push") { const { data: list_prs_of_commit } = await github.rest.repos.listPullRequestsAssociatedWithCommit({ commit_sha: context.sha, @@ -22,6 +20,8 @@ module.exports = async ({ context, core, exec, github }) => { pr_number = pr.number; } else if (context.eventName === "merge_group") { pr_number = parseInt(context.ref.split("/pr-")[1]); + } else { + pr_number = context.issue.number || 0; } // Check for Tofu CLI path.