Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when pressing copy in the JSON formatter when output is empty #11

Closed
winston-de opened this issue Oct 1, 2021 · 1 comment · Fixed by #17
Closed

Crash when pressing copy in the JSON formatter when output is empty #11

winston-de opened this issue Oct 1, 2021 · 1 comment · Fixed by #17
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@winston-de
Copy link

Describe the bug
Clicking copy in the json formatter output when the output is empty will cause the app to crash.

To Reproduce
Steps to reproduce the behavior:

  1. go to json formatter
  2. clear input, if there is any
  3. press copy
  4. app crashes

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Configuration (please complete the following information):

  • OS & Version: Windows 10 19043.1237
  • Theme: both
  • DevToys app version [e.g 0.5.0.0]

Additional context
Add any other context about the problem here.
@veler veler added bug Something isn't working good first issue Good for newcomers labels Oct 1, 2021
@veler
Copy link
Collaborator

veler commented Oct 1, 2021

Hi,

Thank you for sharing this feedback! I've been able to reproduce it easily. I will try to fix it this weekend. :)

@btiteux btiteux mentioned this issue Oct 3, 2021
Merged
10 tasks
@veler veler linked a pull request Oct 3, 2021 that will close this issue
added null check on empty document on copy button click #17
Merged
10 tasks
@veler veler closed this as completed in #17 Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added null check on empty document on copy button click DevToys-app/DevToys
2 participants
@veler @winston-de