Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex Tester: Windows 10 Dark Mode's color scheme causes the matched text to not be visible when out of focus #681

Closed
kennypu opened this issue Sep 30, 2022 · 1 comment · Fixed by #983
Labels
bug Something isn't working
Milestone

Comments

@kennypu
Copy link

kennypu commented Sep 30, 2022

Description

On Windows 10, when using Dark theme with the RegEx Tester, the matched text highlight under Text is not visible due to the highlight color being the same as the "not focused" color for Text. Light theme works as expected.

Steps To Reproduce

  1. Set the App Theme to Dark
  2. Use the Regex Tester and match some text

NOTE: I noticed that on certain reloads, the highlight text is different/lighter, causing it to be fine/visible. I would assume that is a separate issue.

Expected behavior

Either:

  1. Adjust the matching text highlight color to be something with clear contrast for dark theme;
  2. Add setting to adjust highlight colors through-out the app so we can adjust it ourselves.

DevToys Version

Version 1.0.10.0 | X64 | RELEASE | b949a18 | b949a18

Relevant Assets/Logs

Light Theme Example
image

Dark Theme Example when Text is out of focus, eg. when the cursor is in "Regular Expressions"
image

Dark Theme Example when Text is in focus (here highlight is visible, but contrast is very low)
image

@kennypu kennypu added the bug Something isn't working label Sep 30, 2022
@veler veler added this to the v2.0 milestone Mar 18, 2023
@veler
Copy link
Collaborator

veler commented Nov 18, 2023

Hi,
Here is a preview of what I'm working on for DevToys 2.0. The colors won't follow the system's accent color and are better adapted to the dark/light theme.

image

@veler veler linked a pull request Nov 20, 2023 that will close this issue
18 tasks
@veler veler closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants