Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Poloniex backfill not retrieving all possible trades #1564

Open
bradrisse opened this issue Apr 25, 2018 · 0 comments
Open

Poloniex backfill not retrieving all possible trades #1564

bradrisse opened this issue Apr 25, 2018 · 0 comments
Labels
enhancement exchange Relating to an exchange

Comments

@bradrisse
Copy link
Contributor

Currently the poloniex trade history api says "Returns the past 200 trades for a given market, or up to 50,000 trades between a range specified in UNIX timestamps by the "start" and "end" GET parameters."

Zenbot currently adds or subtracts 12 hours when backfilling https://github.com/DeviaVir/zenbot/blob/unstable/extensions/exchanges/poloniex/exchange.js#L62.

The issue if more than 50k trades occurred within the timeframe of 12 hours, then trades are missed.

To fix a check should be in place to check if 50k or greater is returned. If true then re-call the previous trade history in smaller intervals until less than 50k is reached. Once complete resume 12 hour ranges.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement exchange Relating to an exchange
Projects
None yet
Development

No branches or pull requests

2 participants