Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

use_fee_asset setting #1728

Closed
hyuce opened this issue Oct 4, 2018 · 8 comments
Closed

use_fee_asset setting #1728

hyuce opened this issue Oct 4, 2018 · 8 comments

Comments

@hyuce
Copy link
Contributor

hyuce commented Oct 4, 2018

System information

  • Have I written custom code (as opposed to using zenbot vanilla):No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Mint 19 (Ubuntu bionic based)
  • Zenbot version (commit ref, or version): 4.1.4 / Commits on Oct 1, 2018
  • Zenbot branch: unstable
  • NodeJS version: 8.12.0
  • Python version (when using a python script): 3.6.6
  • Exact command to reproduce (include everything):
  • Did I make any changes to conf-sample.js?: No

Describe the problem

When I execute the below code

foo@bar:~$ ./gen.binance.xxx-usdt.sh --conf=conf-binance.XXX-USDT.js --use_fee_asset  --debug 

Live trade shows current in trade options as follows. Also the option has conf file like c.use_fee_asset = true .

Source code / Error logs

use_fee_asset: false,

Why doesn't it handle this parameter?
What should I do?

@hyuce
Copy link
Contributor Author

hyuce commented Oct 10, 2018

I tried everything but I couldn't succeed. a tip is enough.

@stale
Copy link

stale bot commented Dec 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 9, 2018
@hyuce
Copy link
Contributor Author

hyuce commented Dec 10, 2018

My problem is still continuing. Does anyone use this setting?

@stale stale bot removed the wontfix label Dec 10, 2018
@BAKFR
Copy link
Contributor

BAKFR commented Dec 10, 2018

I've looked into the code: seems like use_fee_asset don't change anything to live orders.
The only change is in the computation of estimated fees (displayed on debug, and used to detect orders too small).

Anyway, if you want to pay the fees using the exchange's currency, you should look into the exchange settings.

@hyuce
Copy link
Contributor Author

hyuce commented Dec 10, 2018

I use BNB for Fee at Binance. Can't I use use_fee_asset for this fee?

@BAKFR
Copy link
Contributor

BAKFR commented Dec 10, 2018

I'm not 100% sure, but I think Zenbot will use BNB if you have enabled BNB fees on Binance.

The Binance API doesn't have any way to specify this setting.

@hyuce
Copy link
Contributor Author

hyuce commented Dec 12, 2018

You are absolutely right. Zenbot use BNB if I have enabled BNB fees on Binance. There's a situation like this #1735 . It's making the calculation wrong.

@stale
Copy link

stale bot commented Feb 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants