From 64ee1515e4ed92ca35191c683db0468c8e65d43a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Beno=C3=AEt=20CORTIER?= Date: Wed, 10 Jan 2024 02:17:52 +0900 Subject: [PATCH] Code review --- crates/ironrdp-connector/src/channel_connection.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/ironrdp-connector/src/channel_connection.rs b/crates/ironrdp-connector/src/channel_connection.rs index 4b6d88e7c..0f206a191 100644 --- a/crates/ironrdp-connector/src/channel_connection.rs +++ b/crates/ironrdp-connector/src/channel_connection.rs @@ -146,7 +146,7 @@ impl Sequence for ChannelConnectionSequence { // > 10.0, and 10.1 clients send all of the Channel Join Requests to the server in a // > single batch to minimize the overall connection sequence time. ChannelConnectionState::SendChannelJoinRequest { user_channel_id } => { - let mut written = 0; + let mut total_written: usize = 0; for channel_id in self.channel_ids.iter().copied() { let channel_join_request = mcs::ChannelJoinRequest { @@ -156,11 +156,14 @@ impl Sequence for ChannelConnectionSequence { debug!(message = ?channel_join_request, "Send"); - written += ironrdp_pdu::encode_buf(&channel_join_request, output).map_err(ConnectorError::pdu)?; + let written = + ironrdp_pdu::encode_buf(&channel_join_request, output).map_err(ConnectorError::pdu)?; + + total_written = total_written.checked_add(written).expect("small join request PDUs"); } ( - Written::from_size(written)?, + Written::from_size(total_written)?, ChannelConnectionState::WaitChannelJoinConfirm { user_channel_id }, ) }