From b4ed8456956917521a37e5ac24bae10742705175 Mon Sep 17 00:00:00 2001
From: Krista House <khouse@devolutions.net>
Date: Tue, 14 May 2024 12:11:20 -0400
Subject: [PATCH] fix(webapp): add tooltip to menu warning icon when session is
 closed (#852)

Issue: DGW-145
---
 .../menu-list-active-sessions.component.html               | 7 +++++--
 webapp/src/client/app/shared/models/web-session.model.ts   | 2 ++
 .../src/client/app/shared/services/web-session.service.ts  | 7 ++++++-
 3 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.html b/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.html
index cac5811fb..e7950304d 100644
--- a/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.html
+++ b/webapp/src/client/app/modules/base/menu/menu-list-active-sessions/menu-list-active-sessions.component.html
@@ -1,15 +1,18 @@
 <ng-container *ngFor="let activeWebSession of activeWebSessions;">
   <div class="menu-list-item-container">
     <div class="menu-list-item"
-         [pTooltip]="activeWebSession.name"
          [class.selected]="activeWebSessionIndex === activeWebSession.tabIndex"
          (click)="onMenuListItemClick($event, activeWebSession)">
 
       <div class="left-content">
-        <i *ngIf="activeWebSession.icon" class="dvl-icon" [ngClass]="activeWebSession.icon"></i>
+        <i *ngIf="activeWebSession.icon"
+           class="dvl-icon"
+           [pTooltip]="activeWebSession.iconTooltip"
+           [ngClass]="activeWebSession.icon"></i>
         <span class="menu-list-item-label" tooltipEllipsis>{{activeWebSession.name}}</span>
       </div>
       <p-button (onClick)="onCloseButtonClick($event, activeWebSession)"
+                [pTooltip]="'Close Session'"
                 aria-label="Close session"
                 icon="dvl-icon dvl-icon-close"
                 iconPos="left"></p-button>
diff --git a/webapp/src/client/app/shared/models/web-session.model.ts b/webapp/src/client/app/shared/models/web-session.model.ts
index f9a1fcb7c..77886fda6 100644
--- a/webapp/src/client/app/shared/models/web-session.model.ts
+++ b/webapp/src/client/app/shared/models/web-session.model.ts
@@ -24,6 +24,7 @@ export class WebSession<WebSessionComponentType, TData> {
   public tabIndex?: number;
   public data?: TData;
   public icon?: string = '';
+  public iconTooltip?: string = '';
   public status: ComponentStatus;
   public desktopSize: DesktopSize;
 
@@ -42,6 +43,7 @@ export class WebSession<WebSessionComponentType, TData> {
     this.component = component;
     this.data = data;
     this.icon = icon;
+    this.iconTooltip = name;
     this.tabIndex = tabIndex;
     this.id = id;
     this.sessionId = sessionId;
diff --git a/webapp/src/client/app/shared/services/web-session.service.ts b/webapp/src/client/app/shared/services/web-session.service.ts
index 2eea1c9e8..79c7be610 100644
--- a/webapp/src/client/app/shared/services/web-session.service.ts
+++ b/webapp/src/client/app/shared/services/web-session.service.ts
@@ -120,13 +120,18 @@ export class WebSessionService {
     this.setWebSessionCurrentIndex(this.NEW_SESSION_IDX);
   }
 
+  //For translation ConnectionHasBeenTerminatedEllipsis
   async updateWebSessionIcon(updateWebSessionId: string, icon: string): Promise<void> {
-    const currentSessions = this.webSessionDataSubject.value;
+    const currentSessions: WebSession<any, any>[] = this.webSessionDataSubject.value;
     const index: number = currentSessions.findIndex(session => session.id === updateWebSessionId);
     const webSession: WebSession<any, any> = currentSessions[index];
 
     if (index !== -1) {
       webSession.icon = icon;
+      if (icon === WebClientRdpComponent.DVL_WARNING_ICON) {
+        webSession.iconTooltip = 'Connection has been terminated.';
+      }
+
       currentSessions[index] = webSession;
       this.webSessionDataSubject.next(currentSessions);
     } else {