Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dgw): network scan HTTP API #689

Merged
merged 7 commits into from
Feb 13, 2024
Merged

feat(dgw): network scan HTTP API #689

merged 7 commits into from
Feb 13, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Feb 11, 2024 •
edited
Loading

Added basic api websocket endpoint for network scan

CBenoit
CBenoit reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

devolutions-gateway/Cargo.toml Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
devolutions-gateway/src/api/network_scan.rs Outdated Show resolved Hide resolved
@CBenoit CBenoit changed the title feat(network-scan): basic api endpoint for network scan feat(dgw): network scan HTTP API Feb 12, 2024
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Feb 12, 2024
Merged
CBenoit
CBenoit approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I still have one last concern raised here, but we’ll discuss this on slack. Nothing is blocking, let’s merge! 🚀

@CBenoit CBenoit enabled auto-merge (squash) February 13, 2024 14:17
@CBenoit CBenoit merged commit 846f21d into master Feb 13, 2024
16 checks passed
@CBenoit CBenoit deleted the Network-Scan-Api branch February 13, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @CBenoit