-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webapp): add ssh key authentication #796
Conversation
this.canConnectExtraCallback = () => callback(); | ||
} | ||
|
||
resetCanConnectCallback(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be picky here and ask to add a space after the parathesis 🧐 Everything else looks great though!
resetCanConnectCallback() {
Code looks good. Nice job @irvingoujAtDevolution! I agree adding the extraData attribute is a good idea when creating new session. I will add Paul's comments so we can keep @CBenoit in the loop: Following the UI in DVLS for the ssh key: We usually display the key in a text box, after the user uploads the key. The text box could also allow the user to type the key manually or paste it in quickly. |
Thank you! This is a sensible UX. Code-wise, I have nothing more to add! |
GW.private.key.working.after.udpate.mp4updated as described |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is it still possible to drag and drop the file?
...rc/client/app/modules/web-client/form/form-controls/file-control/file-control.component.html
Outdated
Show resolved
Hide resolved
...rc/client/app/modules/web-client/form/form-controls/file-control/file-control.component.html
Outdated
Show resolved
Hide resolved
No, it is not implemented for this text area, but it is possible to do it. |
…le-control/file-control.component.html Co-authored-by: Benoît Cortier <bcortier@proton.me>
…le-control/file-control.component.html Co-authored-by: Benoît Cortier <bcortier@proton.me>
Do you think you could check with Paul or Krista if this should be implemented? |
sure, that's a good idea. |
GW.final.versio.private.key.mp4 |
LGTM! Well done @irvingoujAtDevolution! 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!!
demo video:
private.key.working.demo.mp4
I tried to use PrimeNG file upload component, but it does not suit our need.
Please let me know if by using extraData attribute a good idea when creating new session.