Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dgw): add recording_storage_is_writeable in heartbeat #835

Merged
merged 1 commit into from
May 2, 2024

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented May 2, 2024

Issue: DGW-175

@CBenoit CBenoit requested a review from a team May 2, 2024 11:35
@CBenoit CBenoit enabled auto-merge (squash) May 2, 2024 11:36
@@ -17,6 +17,8 @@ pub(crate) struct Heartbeat {
version: &'static str,
/// Number of running sessions
running_session_count: usize,
/// Whether the recording storage is writteable or not.
recording_storage_is_writteable: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: writeable

@thenextman thenextman disabled auto-merge May 2, 2024 12:12
Copy link
Member

@thenextman thenextman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one nitpick comment; I disabled auto merge in case you want to fix it before merging

@CBenoit CBenoit changed the title feat(dgw): add recording_storage_is_writteable in heartbeat feat(dgw): add recording_storage_is_writeable in heartbeat May 2, 2024
@CBenoit CBenoit enabled auto-merge (squash) May 2, 2024 13:26
@CBenoit
Copy link
Member Author

CBenoit commented May 2, 2024

Made one nitpick comment; I disabled auto merge in case you want to fix it before merging

Oops! Thank you!

@CBenoit CBenoit merged commit a209dc6 into master May 2, 2024
20 checks passed
@CBenoit CBenoit deleted the DGW-175 branch May 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants