perf(jetsocat,dgw): remove to_vec calls from JMUX implementation #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing a few `to_vec()` calls and reusing the `Bytes` buffer as-is, perfomance of JMUX proxy is increased by ~62.3%. Performance was measured using `iperf` on local network. JMUX proxy performance before this patch: > 0.0000-10.0493 sec 8.21 GBytes 7.02 Gbits/sec JMUX proxy performance after this patch: > 0.0000-19.0245 sec 25.2 GBytes 11.4 Gbits/sec This is still 78.6% slower than jetsocat regular TCP port forwarding.
CBenoit
force-pushed
the
perf/jmux-proxy-1
branch
from
7c5cf73
to
0090205
Compare
awakecoding
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing a few
to_vec()calls and reusing theBytesbuffer as-is, perfomance of JMUX proxy is increased by ~62.3%.Performance was measured using
iperfon local network.JMUX proxy performance before this patch:
JMUX proxy performance after this patch:
This is still 78.6% slower than jetsocat regular TCP port forwarding.