Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and complete Nabla's CMake ASAN code, find workaround for the Sanitanizer to be seen in a project's properties, correct some CMake variables that sometimes may bring mess to CMake cache and a project's compile or link options #423

Open
AnastaZIuk opened this issue Sep 28, 2022 · 0 comments
Labels
bug Something isn't working CMake Build System

Comments

@AnastaZIuk
Copy link
Member

In order to make ASAN work with Nabla we had to remove RTC1 flags from Nabla targets in Debug configuration that were inserted by default by CMake initialization. However we were in hurry and CMake's ASAN code needs more corrections, also we need to fix CMAKE_CXX_*** variables because sometimes they get overriden and appended too many times, they should not repeat in a cache.

There is also an issue with a project's properites not seeing Sanitanizer enabled, it's because CMake cannot handle ASAN properly. It should append <EnableASAN>true</EnableASAN> to a project's .vcxproj file, but it doesn't and it seems to not provide any option enabling it. We will need to provide a workaround which would insert that property.

@AnastaZIuk AnastaZIuk added the bug Something isn't working label Sep 28, 2022
@AnastaZIuk AnastaZIuk changed the title Correct and complete Nabla's CMake ASAN code, find workaround for the Sanitanizer to be seen in a project's properties, correct some CMake variables get sometimes may bring mess to CMake cache and a project's compile or link options Correct and complete Nabla's CMake ASAN code, find workaround for the Sanitanizer to be seen in a project's properties, correct some CMake variables that sometimes may bring mess to CMake cache and a project's compile or link options Sep 28, 2022
@AnastaZIuk AnastaZIuk added the CMake Build System label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake Build System
Projects
None yet
Development

No branches or pull requests

1 participant