Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Error #2

Closed
Reldey opened this issue Mar 26, 2019 · 6 comments
Closed

Documentation Error #2

Reldey opened this issue Mar 26, 2019 · 6 comments

Comments

@Reldey
Copy link

Reldey commented Mar 26, 2019

Readme states to use 'npm run install' however there is no 'install' method defined in package.json. Should be just 'npm install'.

@marcusjwhelan
Copy link

Also, maybe this is just me but dev only builds the project. I have to run start to get the application to show up.

@jkhaui
Copy link

jkhaui commented Oct 22, 2019

@Devtopgraphy please fix the documentation if you're gonna keep it as an open-source repo, it takes like 2 seconds to correct. I nearly turned away from using this because I assumed it had bugs like so many of the other electron/react boilerplates

@iamWing
Copy link
Member

iamWing commented Nov 29, 2019

Also, maybe this is just me but dev only builds the project. I have to run start to get the application to show up.

No it's not just you, it's designed to work in this way. The npm run dev command starts a watcher process in your terminal to monitor the changes made in the source code and performs live rebuild on code modified. You'll need to run npm start in an separate CLI instance if you wanna get the application show up.

@iamWing
Copy link
Member

iamWing commented Nov 29, 2019

@Devtopgraphy please fix the documentation if you're gonna keep it as an open-source repo, it takes like 2 seconds to correct. I nearly turned away from using this because I assumed it had bugs like so many of the other electron/react boilerplates

Mate, sorry for the late reply, my schedule was awfully full over the last couple months. I'll have the doc fixed alongside with some dependencies updates likely in this weekend, but maybe next time you can help fixing the issue and make a pull request so the issue can be fixed asap? Thanks.

@iamWing
Copy link
Member

iamWing commented Dec 2, 2019

6a5b75b has addressed the issue. I'm closing this for now.

@iamWing iamWing closed this as completed Dec 2, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using Discussions for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants