Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Compose is a better way to provide dynamic theming. #8

Open
DeweyReed opened this issue Nov 7, 2019 · 2 comments
Open

Jetpack Compose is a better way to provide dynamic theming. #8

DeweyReed opened this issue Nov 7, 2019 · 2 comments

Comments

@DeweyReed
Copy link
Owner

DeweyReed commented Nov 7, 2019

After playing around with Jetpack Compose, I find that it supports changing view colors through color int instead of styles out of box. By the time of its stable release, this library may be replaced and deprecated.

@DeweyReed DeweyReed pinned this issue Nov 27, 2019
@ianrumac
Copy link

Why so?

Most apps won't use compose in production for at least 2-3 years, and they mostly won't translate their codebases. And making an API that can be used with both compose and non-compose will be a great way to extend this library's lifecycle when the time comes :)

@DeweyReed
Copy link
Owner Author

DeweyReed commented May 27, 2020

@ianrumac This library is experimental and fragile and heavily depends on material-components-android. If you use this library in the production, you have to prepare to maintain the code every release of Android or material-components-android because everything will be changed. Besides, compound views like custom views or MaterialDateTimePicker are very hard to be tinted unless we deeply hook into Android Resources and View system, which makes the libary more fragile.

Since Jetpack Compose's able to do the work, I'll leave the job to it when the time is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants