Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address for en-NZ Locale is coming with USA specific addresses #720

Open
vibinernesto opened this issue May 9, 2022 · 2 comments
Open

Comments

@vibinernesto
Copy link

Describe the bug
Address for en-NZ Locale is coming with USA specific addresses. Names as well.

To Reproduce

Faker feku = new Faker(new Locale("en-NZ"));
System.out.println("First Name ---- "+feku.name().firstName());
System.out.println("Last Name ---- "+feku.name().lastName());
System.out.println("Street Address ---- "+feku.address().streetAddress());
System.out.println("City ---- "+feku.address().city());
System.out.println("State ---- "+feku.address().state());
System.out.println("zipCode ---- "+feku.address().zipCode());

It generates below output:

First Name ---- Sophia
Last Name ---- Hahn
Street Address ---- 4209 Cassin Way
City ---- Robertsshire
State ---- California
zipCode ---- 7236

None of them looks like the NZ address book

**Additional comments : **
It makes more sense to add the Maori names in the New Zealand names too

Versions:

  • JDK 8
  • Faker Version 1.0.2
@bodiam
Copy link

bodiam commented May 9, 2022

@vibinernesto could you try out Datafaker.net, and see if the issue is there too? We should have fixed a lot of issues currently affecting Javafaker.

update: I just checked it, and it's affecting Datafaker too. It's just because there's no data for en-NZ for this, same as en-GB, en-IND, en-CA, etc. Feel free to add this data and do a PR.

@ak-maker
Copy link

Hello @vibinernesto , I would like to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants