Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/parsers/ebml missing from sdist for 0.5.0 #40

Closed
mgorny opened this issue Jun 24, 2024 · 5 comments · Fixed by #41
Closed

tests/parsers/ebml missing from sdist for 0.5.0 #40

mgorny opened this issue Jun 24, 2024 · 5 comments · Fixed by #41

Comments

@mgorny
Copy link
Contributor

mgorny commented Jun 24, 2024

The sdist archive for 0.5.0 is missing the tests/parsers/ebml directory, which leads to test failures:

____________________________________________________ EBMLTestCase.test_parse_full _____________________________________________________

self = <test_parsers.EBMLTestCase testMethod=test_parse_full>

    def setUp(self):
        self.stream = io.open(os.path.join(TEST_DIR, "test1.mkv"), "rb")
>       with io.open(os.path.join(EBML_VALIDATION_DIR, "test1.mkv.yml"), "r") as yml:
E       FileNotFoundError: [Errno 2] No such file or directory: '/tmp/portage/dev-python/enzyme-0.5.0/work/enzyme-0.5.0/tests/parsers/e
bml/test1.mkv.yml'

self       = <test_parsers.EBMLTestCase testMethod=test_parse_full>

tests/test_parsers.py:27: FileNotFoundError

(and so on)

@Diaoul
Copy link
Owner

Diaoul commented Jun 24, 2024

Ah it's tests! Yes I think I did not include those, I guess I should then.

Thanks for the report 🙏

@Diaoul
Copy link
Owner

Diaoul commented Jun 24, 2024

Should be fixed in 0.5.1 📦

@Diaoul Diaoul closed this as completed Jun 24, 2024
@mgorny
Copy link
Contributor Author

mgorny commented Jun 24, 2024

I'm afraid that didn't work. 0.5.1 is still missing that file.

@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

Ah yes indeed, I focused on fixing matroska.xml that I broke when reworking the packaging 🤦

@Diaoul Diaoul reopened this Jun 25, 2024
@Diaoul Diaoul closed this as completed in 34a7bda Jun 25, 2024
@Diaoul
Copy link
Owner

Diaoul commented Jun 25, 2024

Released 0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants