Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command ZCARD #1129

Closed
JyotinderSingh opened this issue Oct 17, 2024 · 6 comments · Fixed by #1195
Closed

Add support for command ZCARD #1129

JyotinderSingh opened this issue Oct 17, 2024 · 6 comments · Fixed by #1195

Comments

@JyotinderSingh
Copy link
Collaborator

Add support for the ZCARD command in DiceDB similar to the ZCARD command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@swarajrb7
Copy link
Contributor

@JyotinderSingh can I pick this issue?

@JyotinderSingh
Copy link
Collaborator Author

@JyotinderSingh can I pick this issue?

Assigned.

@c-harish
Copy link
Contributor

Hi @JyotinderSingh. Since @swarajrb7 is working on LATENCY, can I take this one?

@JyotinderSingh
Copy link
Collaborator Author

Hi @JyotinderSingh. Since @swarajrb7 is working on LATENCY, can I take this one?

Sounds good.

@arpitbbhayani
Copy link
Contributor

Hello @c-harish,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@c-harish
Copy link
Contributor

Hello @c-harish,

There has been no activity on this issue for the past 5 days. It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

Hi @arpitbbhayani. Will raise PR tonight.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants