Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#998: Added GET.UNWATCH command support and fix watch related issues #1201

Merged
merged 12 commits into from
Nov 4, 2024

Conversation

psrvere
Copy link
Contributor

@psrvere psrvere commented Oct 26, 2024

Closes #998

Changes

  1. Implemented GET.UNWATCH command in RESP server with integration tests.
  2. Updated Dice SDK version to fix a minor bug

Bug Fixes

  1. Fixed panic in GET.WATCH command when called without arguments
  2. Fixed premature fingerprint deletion in handleUnsubscription function (watch_manager.go). This prevented execution of the next cleanup block.
  3. Corrected cmdWatchSubscriptionChan initialisation that was incorrectly set to nil in PR Changed scope of CmdWatchSubscriptionChan to local #1169

@psrvere psrvere changed the title Added GET.UNWATCH command Added GET.UNWATCH command support and fix watch related issues Oct 26, 2024
@psrvere psrvere marked this pull request as ready for review October 31, 2024 02:28
@psrvere
Copy link
Contributor Author

psrvere commented Oct 31, 2024

@JyotinderSingh - Please reivew.

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @psrvere! I believe there is a slight misunderstanding on how the command works. I've explained it in my other comment. I don't think it will take too much effort to make that change.

internal/worker/worker.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick resolution to the comments @psrvere! The changes look and well tested. Thanks for making the required SDK changes too.

Approved!

@JyotinderSingh JyotinderSingh changed the title Added GET.UNWATCH command support and fix watch related issues #998: Added GET.UNWATCH command support and fix watch related issues Nov 4, 2024
@JyotinderSingh JyotinderSingh merged commit 680b83c into DiceDB:master Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GET.UNWATCH command
2 participants