Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1030: Migrate JSON.RESP & JSON.DEBUG #1277

Merged
merged 10 commits into from
Nov 14, 2024
Merged

#1030: Migrate JSON.RESP & JSON.DEBUG #1277

merged 10 commits into from
Nov 14, 2024

Conversation

c-harish
Copy link
Contributor

@c-harish c-harish commented Nov 13, 2024 •
edited
Loading

Migrates JSON.RESP and JSON.DEBUG

PR Checklist

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.
  • Add relevant documentation.

JSON.INGEST is being migrated as a part of #1276
This PR partially resolves #1030

@apoorvyadav1111
Copy link
Contributor

Hi @c-harish , thanks for quickly creating a draft PR. #1276 will merge soon and will have some essential fixes, Please rebase the PR once it completes all the checkboxes and let us know to close this before another conflict.

@c-harish c-harish marked this pull request as ready for review November 13, 2024 15:28
apoorvyadav1111
apoorvyadav1111 requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes so quickly. I think usually in migration, we also update cmd_meta.go in worker folder. Please confirm on this one along with the comments.

Thanks

integration_tests/commands/resp/jsondebug_test.go Outdated Show resolved Hide resolved
integration_tests/commands/resp/jsonresp_test.go Outdated Show resolved Hide resolved
integration_tests/commands/websocket/jsondebug_test.go Outdated Show resolved Hide resolved
integration_tests/commands/websocket/jsonresp_test.go Outdated Show resolved Hide resolved
internal/eval/store_eval.go Outdated Show resolved Hide resolved
@apoorvyadav1111 apoorvyadav1111 merged commit 88e4961 into DiceDB:master Nov 14, 2024
2 checks passed
@apoorvyadav1111 apoorvyadav1111 mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvyadav1111 apoorvyadav1111 apoorvyadav1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command Migration: ('JSON.RESP', 'JSON.DEBUG', 'JSON.INGEST')
2 participants
@c-harish @apoorvyadav1111