Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed makefile and removed outdated content from readme #1310

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fixed makefile and removed outdated content from readme #1310

merged 3 commits into from
Nov 22, 2024

Conversation

vinitparekh17
Copy link
Contributor

@vinitparekh17 vinitparekh17 commented Nov 20, 2024 •
edited
Loading

  • Added a reference guide on well-documented Makefiles.
  • Moved the release target to a new Deployment section for better organization.
  • removed outdated readme content

@vinitparekh17 vinitparekh17 changed the title chore: makefile fixed makefile and removed outdated content from readme Nov 21, 2024
@vinitparekh17
Copy link
Contributor Author

@JyotinderSingh This PR includes minor but necessary changes in readme and makefile

JyotinderSingh
JyotinderSingh approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JyotinderSingh JyotinderSingh merged commit ad3eb90 into DiceDB:master Nov 22, 2024
1 check passed
@vinitparekh17 vinitparekh17 deleted the patch-1 branch November 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JyotinderSingh JyotinderSingh JyotinderSingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinitparekh17 @JyotinderSingh