PHP CS Fixer 2.0.x not working #15

vysker · 2016-12-15T10:01:15Z

A lot of users are reporting that this extension does not work with PHP CS Fixer 2.0.x. So this issue will be here to accumulate as much info about the problem at hand.

If you are running into this issue as well, please post the following info:

OS.
VSCode version.
PHP CS Fixer version.
PHPFormatter version.
PHPFormatter user settings.
PHPFormatter logging output (use phpformatter.logging: true).
If possible, a snippet or screenshot of the code that needs formatting.

I will try to work out a solution soon enough. Time might be an issue around all the upcoming festivities, however.

Thanks!

The text was updated successfully, but these errors were encountered:

Join-Git-Hub · 2016-12-15T11:35:41Z

OK, Thanks, here are my current Settings ✏️

OS.

Windows 7 Home Premium

VSCode version.

Version 1.8.0

PHP CS Fixer version.

2.0.0

PHPFormatter version

0.2.4

PHPFormatter user settings.

{
    "window.zoomLevel": 1.5,
    "editor.lineHeight": 28,
    "telemetry.enableTelemetry": false,
    "telemetry.enableCrashReporter": false,
    "php.validate.executablePath": "c:/xampp/php/php.exe",
    "phpformatter.phpPath": "C:/xampp/php/php.exe",
    "phpformatter.pharPath": "c:/xampp/php/php-cs-fixer.phar",
    "phpformatter.logging": true
}

PHPFormatter logging output (use phpformatter.logging: true).

If possible, a snippet or screenshot of the code that needs formatting.

class ControllerErrorPermission extends Controller {
	public function index() {
		$this->load->language('error/permission');

		$this->document->setTitle($this->language->get('heading_title'));

		$data['heading_title'] = $this->language->get('heading_title');

		$data['text_permission'] = $this->language->get('text_permission');

		$data['breadcrumbs'] = array();

		$data['breadcrumbs'][] = array(
			'text' => $this->language->get('text_home'),
			'href' => $this->url->link('common/dashboard', 'token=' . $this->session->data['token'], 'SSL')
		);

		$data['breadcrumbs'][] = array(
			'text' => $this->language->get('heading_title'),
			'href' => $this->url->link('error/permission', 'token=' . $this->session->data['token'], 'SSL')
		);

		$data['header'] = $this->load->controller('common/header');
		$data['column_left'] = $this->load->controller('common/column_left');
		$data['footer'] = $this->load->controller('common/footer');

		$this->response->setOutput($this->load->view('error/permission.tpl', $data));
	}

	public function check() {
		if (isset($this->request->get['route'])) {
			$route = '';

			$part = explode('/', $this->request->get['route']);

			if (isset($part[0])) {
				$route .= $part[0];
			}

			if (isset($part[1])) {
				$route .= '/' . $part[1];
			}

			$ignore = array(
				'common/dashboard',
				'common/login',
				'common/logout',
				'common/forgotten',
				'common/reset',
				'error/not_found',
				'error/permission',
				'dashboard/order',
				'dashboard/sale',
				'dashboard/customer',
				'dashboard/online',
				'dashboard/map',
				'dashboard/activity',
				'dashboard/chart',
				'dashboard/recent'
			);

			if (!in_array($route, $ignore) && !$this->user->hasPermission('access', $route)) {
				return new Action('error/permission');
			}
		}
	}
}

sergiufp · 2016-12-15T19:05:07Z

I am experiencing a similar error:

PHPFormatter: Full command being executed: "E:\Web\UwAmp\bin\php\php-7.1.0-Win32-VC14-x86\php.exe" "E:\Web\UwAmp\bin\php\php-7.1.0-Win32-VC14-x86\phpcs.phar" fix "C:\Users\sergi\AppData\Local\Temp\phpfmt-7716K5NoyoCpqMqO.tmp" --level=psr2
PHPFormatter: Logging PHP-CS-Fixer command stdout result
PHPFormatter: ERROR: The file "fix" does not exist.

OS: Windows 10 Pro x64
VSCode version: 1.7.2
PHP CS Fixer version: 2.0.0
PHPFormatter version: 0.2.4
PHPFormatter user settings:

"phpformatter.pharPath": "E:\\Web\\UwAmp\\bin\\php\\php-7.1.0-Win32-VC14-x86\\phpcs.phar",
"phpformatter.phpPath": "E:\\Web\\UwAmp\\bin\\php\\php-7.1.0-Win32-VC14-x86\\php.exe",
"phpformatter.logging": true,

Later edit: issue persists after updating VSCode to version 1.8.0

yaliv · 2016-12-20T04:25:53Z

OS: Zorin OS 12 64-bit.
VSCode version: 1.8.1.
PHP CS Fixer version: 2.0.0.
PHPFormatter version: 0.2.4.
PHPFormatter user settings:

"phpformatter.composer": true,
"phpformatter.logging": true

PHPFormatter logging output: I don't know how to see the logging output.
My code snippets that needs formatting:

    public function actionItemDetail()
    {
        $title = Yii::$app->request->get('title');

                $data = $this->data();

                        $itemFound = null;

            foreach ($data as $d) {
            if ($d['title'] == $title) {
                $itemFound = $d;
                }
        }

                    return $this->render('itemDetail', ['title' => $title, 'itemFound' => $itemFound]);
    }

Join-Git-Hub · 2016-12-22T08:49:58Z

@yaliv

PHPFormatter logging output: I don't know how to see the logging output.

Klick HELP -> Toggle Developer Tool -> Console

yaliv · 2016-12-23T04:23:04Z

OK, here is the output in the console.

(I use the same versions as here).

Using Composer:

[Extension Host] PHPFormatter: Creating temp file.
[Extension Host] PHPFormatter: Tempfile fd: 61
[Extension Host] PHPFormatter: Tempfile name: /tmp/phpfmt-5947C8m6dUBQqw4n.tmp
[Extension Host] PHPFormatter: Writing current document content to temp file. Until VSCode will have a way of querying encoding, utf8 will be used for reading and writing.
[Extension Host] PHPFormatter: Full command being executed: php-cs-fixer fix "/tmp/phpfmt-5947C8m6dUBQqw4n.tmp" --level=psr2
[Extension Host] PHPFormatter: Logging PHP-CS-Fixer command stderr result
[Extension Host] PHPFormatter: 

  [Symfony\Component\Console\Exception\RuntimeException]
  The "--level" option does not exist.

fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--] [<path>]...

[Extension Host] PHPFormatter: Reading temp file content.
[Extension Host] PHPFormatter: Replacing editor content with formatted code.
[Extension Host] PHPFormatter: Document successfully formatted (19 lines).

Using php-cs-fixer.phar file:

[Extension Host] PHPFormatter: Creating temp file.
[Extension Host] PHPFormatter: Tempfile fd: 61
[Extension Host] PHPFormatter: Tempfile name: /tmp/phpfmt-5947Q0cGP1CpJXtR.tmp
[Extension Host] PHPFormatter: Writing current document content to temp file. Until VSCode will have a way of querying encoding, utf8 will be used for reading and writing.
[Extension Host] PHPFormatter: Full command being executed: "/opt/lampp/bin/php" "$HOME/phar/php-cs-fixer.phar" fix "/tmp/phpfmt-5947Q0cGP1CpJXtR.tmp" --level=psr2
[Extension Host] PHPFormatter: Logging PHP-CS-Fixer command stderr result
[Extension Host] PHPFormatter: 

  [RuntimeException]
  The "--level" option does not exist.

fix [--path-mode="..."] [--allow-risky="..."] [--config="..."] [--dry-run] [--rules="..."] [--using-cache="..."] [--cache-file="..."] [--diff] [--format="..."] [path1] ... [pathN]



[Extension Host] PHPFormatter: Reading temp file content.
[Extension Host] PHPFormatter: Replacing editor content with formatted code.
[Extension Host] PHPFormatter: Document successfully formatted (19 lines).

Sample case:
I copied a code snippet from a PDF document into VS Code, the code was copied without indentation. After trying to use PHPFormatter to format my code, nothing changed.

My code snippet:

<?php
namespace app\controllers;
use Yii;
use yii\web\Controller;
use app\models\Room;
class RoomsController extends Controller
{
public function actionCreate()
{
$model = new Room();
$modelCanSave = false;
if ($model->load(Yii::$app->request->post()) && $model->validate()) {
$modelCanSave = true;
}return $this->render('create', [
'model' => $model,
'modelSaved' => $modelCanSave
]);
}
}

ncwgf · 2016-12-25T13:00:32Z

@yaliv
According to readme of php-cs-fixer https://github.com/FriendsOfPHP/PHP-CS-Fixer#usage
php php-cs-fixer.phar fix /path/to/project --rules=@PSR2
--level should be change to --rules=@psr2

and this extension will add --level=2 by default in setting phpformatter.arguments

just found it was discussed at #13

yaliv · 2016-12-26T03:56:02Z

@ncwgf

OK, it works with --rules argument.

Using @PSR2:

<?php
namespace app\controllers;

use Yii;
use yii\web\Controller;
use app\models\Room;

class RoomsController extends Controller
{
    public function actionCreate()
    {
        $model = new Room();
        $modelCanSave = false;
        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            $modelCanSave = true;
        }
        return $this->render('create', [
'model' => $model,
'modelSaved' => $modelCanSave
]);
    }
}

Using @Symfony:

<?php

namespace app\controllers;

use Yii;
use yii\web\Controller;
use app\models\Room;

class RoomsController extends Controller
{
    public function actionCreate()
    {
        $model = new Room();
        $modelCanSave = false;
        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            $modelCanSave = true;
        }

        return $this->render('create', [
'model' => $model,
'modelSaved' => $modelCanSave,
]);
    }
}

The most difficult to format is the indentation for multi-line array. Any solution?

ncwgf · 2016-12-26T14:36:02Z

it's php-cs-fixer problem and seem it still not ... ready
PHP-CS-Fixer/PHP-CS-Fixer#1438

NewFuture · 2016-12-31T14:09:21Z

https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v2.0.0/UPGRADE.md

😹

vysker · 2017-01-02T11:23:09Z

Thank you all for reporting in. I have been struggling with maintaining support for both versions of PHP CS Fixer for a while now. So in a next update I will be integrating PHP CS Fixer 2.0.0 to circumvent all this.

I will be leaving this issue open so people will have a place to go in the mean time.

lichnow · 2017-01-16T18:09:00Z

[Symfony\Component\Filesystem\Exception\IOException]
Failed to write file ".php_cs.cache", "no reason available".

My setting
{
"phpcs.standard": "PSR2",
"phpformatter.phpPath": "/usr/local/bin/php",
"phpformatter.composer": true,
"phpformatter.logging": true,
"phpformatter.arguments": [
"--rules=@psr2"
]
}

ajkopinga · 2017-01-24T09:15:03Z

@lichnow

I encountered the same 'Failed to write file ".php_cs.cache"' error. Caching only seems useful when fixing multiple files at once, so I skipped caching by adding '--using-cache false' to the phpformatter.arguments setting.

This is a temporary fix to make the formatter work.

kadevland · 2017-03-04T12:00:38Z

ai can't wowrking at all this extention

kadevland · 2017-03-04T18:17:26Z

when a save the file with debuug on i have "spawn php EMFILE"

kadevland · 2017-03-19T21:47:39Z

for me i have change addon.
So it's done for me

lesydat · 2017-03-22T08:23:01Z

I changed this setting from default value

  "phpformatter.arguments": [
    "--level=psr2"
  ],

to this

"phpformatter.arguments": []

It work well

elisecode247 · 2017-04-17T16:47:17Z

@lesydat's solution worked for me.

Tommixoft · 2017-05-24T14:28:38Z

Tried every possible solution - nothing helps. I call this extension bullshit.
If it's not compatible with v2 - so write that in documentation.

nucklearproject · 2017-05-28T16:49:21Z

@lesydat
Work fine now...

dxkite · 2017-06-01T10:48:43Z

change argument --rules=@psr2 to --rules=@PSR2 will work well.
this is my setting

{
    "phpformatter.composer": true,
    "phpformatter.logging": true,
    "phpformatter.arguments": ["--rules=@PSR2"]
 }

@lesydat

bardware · 2018-03-23T23:56:14Z

"--level=psr2"

"--rules=@PSR2"

vysker mentioned this issue Dec 15, 2016

Not Working #9

Closed

vysker self-assigned this Dec 15, 2016

vysker added the bug label Dec 15, 2016

ohnotnow mentioned this issue Nov 1, 2017

'Unknown Error' calebporzio/simple-php-cs-fixer#1

Open

CLOUGH mentioned this issue Dec 11, 2017

Extension does nothing #24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP CS Fixer 2.0.x not working #15

PHP CS Fixer 2.0.x not working #15

vysker commented Dec 15, 2016

Join-Git-Hub commented Dec 15, 2016 •

edited

Loading

sergiufp commented Dec 15, 2016 •

edited

Loading

yaliv commented Dec 20, 2016 •

edited

Loading

Join-Git-Hub commented Dec 22, 2016

yaliv commented Dec 23, 2016 •

edited

Loading

ncwgf commented Dec 25, 2016 •

edited

Loading

yaliv commented Dec 26, 2016

ncwgf commented Dec 26, 2016

NewFuture commented Dec 31, 2016

vysker commented Jan 2, 2017

lichnow commented Jan 16, 2017

ajkopinga commented Jan 24, 2017

kadevland commented Mar 4, 2017

kadevland commented Mar 4, 2017

kadevland commented Mar 19, 2017

lesydat commented Mar 22, 2017

elisecode247 commented Apr 17, 2017

Tommixoft commented May 24, 2017

nucklearproject commented May 28, 2017

dxkite commented Jun 1, 2017

bardware commented Mar 23, 2018

PHP CS Fixer 2.0.x not working #15

PHP CS Fixer 2.0.x not working #15

Comments

vysker commented Dec 15, 2016

Join-Git-Hub commented Dec 15, 2016 • edited Loading

sergiufp commented Dec 15, 2016 • edited Loading

yaliv commented Dec 20, 2016 • edited Loading

Join-Git-Hub commented Dec 22, 2016

yaliv commented Dec 23, 2016 • edited Loading

ncwgf commented Dec 25, 2016 • edited Loading

yaliv commented Dec 26, 2016

ncwgf commented Dec 26, 2016

NewFuture commented Dec 31, 2016

vysker commented Jan 2, 2017

lichnow commented Jan 16, 2017

ajkopinga commented Jan 24, 2017

kadevland commented Mar 4, 2017

kadevland commented Mar 4, 2017

kadevland commented Mar 19, 2017

lesydat commented Mar 22, 2017

elisecode247 commented Apr 17, 2017

Tommixoft commented May 24, 2017

nucklearproject commented May 28, 2017

dxkite commented Jun 1, 2017

bardware commented Mar 23, 2018

Join-Git-Hub commented Dec 15, 2016 •

edited

Loading

sergiufp commented Dec 15, 2016 •

edited

Loading

yaliv commented Dec 20, 2016 •

edited

Loading

yaliv commented Dec 23, 2016 •

edited

Loading

ncwgf commented Dec 25, 2016 •

edited

Loading