-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Carbon Mod to Rust #115
Open
eumario
wants to merge
9
commits into
Didstopia:master
Choose a base branch
from
eumario:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial Add: Carbon Support for Rust Server.
Minor fix
Ensure that server is safeguarded from having both Oxide and Carbon installed, Also added Update on Boot option for Carbon.
Removed Environment.sh check, as we just need to see if Carbon.dll is in it's location. Added check to ensure that we aren't trying to enable both Oxide and Carbon at the same time.
For Production Only, Added Carbon Branch for Preview, and Edge. Only compatible with Production Rust, will not work on Staging, AUX01 or AUX02 releases of Rust.
Fixed Typos in RUST_CARBON_BUILD
Re-worked Logic behind selecting Rust Branch, and Carbon Branch.
Fixed Mis-named Environment Variable in script, now should properly see it.
Updated documentation to reflect the addition of Carbon to the Docker image.
mthsmb
approved these changes
Jul 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes baby, LGTM
When this is planned to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the same methodology for installing Oxide, for the Carbon modding system for Rust. Same options are implemented for Carbon, as well as safety checks to ensure that one or the other mod systems are enabled, not both at the same time.