Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRR not handling exact tag namespaces when searching #444

Closed
ub333 opened this issue Apr 6, 2021 · 4 comments
Closed

LRR not handling exact tag namespaces when searching #444

ub333 opened this issue Apr 6, 2021 · 4 comments

Comments

@ub333
Copy link

ub333 commented Apr 6, 2021

(Running LRR 0.7.7 in Docker)

Not sure if this a total edge case or intended functionality, but anyway: when searching any "male" namespace tag, LRR returns all "female" results as well. E.g. searching for let's say... "male:furry" will also return all "female:furry". This can be avoided by adding a $ and making it an exact search, but it's a little weird and fuzzier than how I've come to expect tag searching to usually work.

Anyway, just letting you know!

@Difegue
Copy link
Owner

Difegue commented Apr 7, 2021

👋 As things are, I'd say it's kinda intended?
The search engine is fuzzy by definition unless you make it an exact search with quotes or $.
I didn't really look in detail as to how other implementations do it so it seemed logical at the time. 🤔

Making it so that the namespace part of a search must be an exact match is a reasonable enhancement request, I'd say.

@Difegue
Copy link
Owner

Difegue commented Jan 6, 2022

I'll try to tackle this in the upcoming search improvement pass.

@Difegue Difegue self-assigned this Jan 6, 2022
@Difegue Difegue pinned this issue Jan 9, 2022
@Difegue Difegue unpinned this issue May 26, 2022
@Difegue
Copy link
Owner

Difegue commented Dec 16, 2022

#555 fixes this: tag searches are now required to be exact and separated by commas.
I plan to eventually bring wildcard support back again if people request it. ✌️

@Difegue Difegue closed this as completed Dec 16, 2022
@Difegue
Copy link
Owner

Difegue commented Dec 18, 2022

small addendum: I added wildcard support back sooner than planned, but did take this into account.

tag searches will be fully wildcard, namespace:tag searches will only be wildcarded at the end (namespace stays intact).
You can use *namespace:tag if you want the old behavior for some weird reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants