Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on iOS 9 #5

Open
lauv-pussaaon opened this issue Feb 8, 2018 · 1 comment
Open

Crash on iOS 9 #5

lauv-pussaaon opened this issue Feb 8, 2018 · 1 comment

Comments

@lauv-pussaaon
Copy link

lauv-pussaaon commented Feb 8, 2018

Hi, I really like this component implementation of yours.

Now when running on iOS 9 it crashes at
guard let attributesCollection = super.layoutAttributesForElements(in: rect) else {
in override open func layoutAttributesForElements(in rect: CGRect)

Can you help me with this issue?

@Chris-Corea
Copy link

For what it's worth, I also ran into this same issue on iOS 9. I found that I was able to fix this by removing the call to copy() in layoutAttributesForItem(...). I'm still unsure what the implications are of not using the copied UICollectionViewLayoutAttributes, but for now I haven't run into any problems. I would submit a PR, but, again, I'm not sure if this would negatively impact performance or cause other potential issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants