Staging deployment failing

[niraymak]

Describe the bug
The Github action which is responsible for the deploying the develop branch to staging environment is failing regularly lately.

https://github.com/DigitalExcellence/dex-backend/actions/workflows/staging-deployment.yml
https://github.com/DigitalExcellence/dex-frontend/actions/workflows/staging-deployment.yml

Ruben and I think this is happening because of the sleep time being too short in the GitHub action (see file below). We think the database is not yet down when the docker-compose up command is starting. If this will solve the problem, the action in production should also be extended.
https://github.com/DigitalExcellence/dex-backend/blob/develop/.github/workflows/staging-deployment.yml#L29

EDIT: EXTENDING TIME TO 25 SECONDS DID NOT HELP.
https://github.com/DigitalExcellence/dex-backend/actions/runs/657962692

Fixed it I think :)
I will test more but I think I found the problem, the compose file has a static IP listed in the database section, no idea what it is for but loads of people seem to advise not to use a static ip since docker can resolve ip's via the service discovery itself. I commented the ip out and the application runs fine without the ip. After some testing the problem seems to be gone :). Will test more during comming PR's and pipeline triggers before closing. - Mees

Expected behavior
GitHub action should succeed.

Screenshots

Production URL

Additional context
The frontend also has a GitHub action for staging deployment.

We fixed this on the server by running

docker-compose down
docker-compose up -d

[niraymak]

Seems like 25s is not enough aswell, will try 90seconds now and test again.

[niraymak]

Still an issue after setting the time to 90s.

https://github.com/DigitalExcellence/dex-backend/actions/runs/664727811

[Brend-Smits]

The sleep was more of a temporary workaround. Consider setting up a proper solution like; https://docs.docker.com/compose/startup-order/ or via healthchecks(preferred I think): https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck in combination with depends_on