Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom ArgumentTypes incorrectly use minecraft namespace #418

Open
unilock opened this issue Jun 19, 2024 · 0 comments
Open

[Bug]: Custom ArgumentTypes incorrectly use minecraft namespace #418

unilock opened this issue Jun 19, 2024 · 0 comments
Assignees
Labels

Comments

@unilock
Copy link

unilock commented Jun 19, 2024

What happened?

@Inject(method = "bootstrap", at = @At("RETURN"))
private static void register(Registry<ArgumentTypeInfo<?, ?>> registry, CallbackInfoReturnable<ArgumentTypeInfo<?, ?>> ci) {
register(registry, "pocket", PocketTemplateArgumentType.class, SingletonArgumentInfo.contextFree(PocketTemplateArgumentType::new));
register(registry, "block_placement_type", BlockPlacementTypeArgumentType.class, SingletonArgumentInfo.contextFree(BlockPlacementTypeArgumentType::blockPlacementType));
}

The code here registers Dimensional Doors' ArgumentTypes with the minecraft namespace (since it doesn't specify its own), which causes issues when connecting to a dedicated server running behind a Velocity proxy, as CrossStitch doesn't know to wrap the ArgumentType so Velocity doesn't complain.

Mod Version

5.3.3-fabric

What versions of Minecraft does this issue happen on?

No response

Log

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants