-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlurView doesn't provide dynamic blur for BottomSheetDialogFragment #216
Comments
I have a suspicion about the root cause. |
@Dimezis can I invite you to a closed repo with the project itself? I think it's better to you to check this one in real-case scenario. I will point to the files where I set up BlurView |
Sure, that would work for me too |
@Dimezis sent an invite. The BlurView is used in PurchaseFragmentBottomSheet.kt at line 101 |
@Dimezis any updates on this issue? |
@hmmmk I am not able to go through the signup process in your app, please just extract the problematic place into a separate example project, or provide a simple way to reproduce the issue in this project. |
@Dimezis okay, I made a branch called blurtest. If you build this branch it will open screen where you should just press on a button with a big heart, it will open BottomSheetFragment, and you'll see the issue |
@Dimezis |
Version 2.0.5 should fix this issue. |
But I select rootView of the whole activity, how it doesn't include bottom bar? |
You don't. Well, not on this branch anyway. val rootView = requireActivity().window.decorView as ViewGroup
bgView.setupWith(rootView) Your setup looks like this instead: val rootView = requireParentFragment().requireParentFragment().requireParentFragment().view as ViewGroup
bgView.setupWith(rootView) |
Yep, you right. I forgot about this. But anyway, I tried to put 2.0.5 and it's still not working as expected |
@Dimezis Could not find com.github.Dimezis:BlurView:version-2.0.5. implementation ("com.github.Dimezis:BlurView:version-2.0.5") |
@krupalivaghasiya24 |
@Dimezis any ideas on how to improve performance when using BlurView as BottomSheetDialogFragment background? |
|
@Dimezis okay, despite that, the issue is solved |
I'm trying to make dynamic blur for a BottomSheetDialog fragment. But the thing is, that BlurView correctly takes snapshot of underlying content and blurs it, but only statically. When I'm trying to move my bottom sheet fragment up and down, blur remains the same, and I want to make it to change when bottom sheet is moving.
Here is how I enable it in the kotlin code:
In the XML layout of BottomSheetDialogFragment, BlurView is just top element of all hierarchy.
The text was updated successfully, but these errors were encountered: