Make some things public to support react-native #201
Conversation
…e custom react native based view class.
library/build.gradle
Outdated
| publishing { | ||
| publications { | ||
| release(MavenPublication) { | ||
| groupId = 'com.github.stemyke' |
There was a problem hiding this comment.
Why would this publishing be included in this repo?
There was a problem hiding this comment.
@Dimezis I was just figuring how should I publish the package, so I can import it into the project I mentioned. This is actually my first time I am doing something with an Android lib.
|
👍 I'm fine with these changes except that maven publishing |
|
@Dimezis Now I removed the publishing part. Can you please merge it then, and release a new version? |
|
I have a question though, what's the point of introducing another BlurView based on |
|
@Dimezis Thats a good question about the mentioned point (positioning), but ReactViewGroup does other things very well, for example border radiuses with custom drawables, which we could not achieve if we wrap it in the BlurView unless we implement it again in our custom view manager. Another thing to mention is that react-native uses these view managers to inject children into other ViewGroups where we dont know anything about the parent View, so we could only inject the child view in JavaScript which would make the lib more complex. |
jitpack.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| jdk: | |||
| - openjdk11 | |||
There was a problem hiding this comment.
No its not, it was also for publishing. Can you remove it or should I do it?
There was a problem hiding this comment.
Please remove it and I'll try to release everything today
There was a problem hiding this comment.
Thanks, I removed it now.
|
It should be accessible on Jitpack soon https://github.com/Dimezis/BlurView/releases/tag/version-2.0.4 |
@Dimezis Thank you very much! |
There is a react-native-community plugin that utilizes this library to make blur effect in react-native projects. However the problem is that this lib only works properly when using child Views inside BlurView. What I want to achieve to create a custom BlurView implementation for react-native which does exactly the same as BlurView in here, but instead of extending FrameLayout it can extend from ReactViewGroup class to utilize fancy flexbox like positioning.