-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chat_id
need to accept type of int and string
#53
Comments
chat_id
need to accept type int and stringchat_id
need to accept type of int and string
Any likelyhood of applying the patch? |
@castaway I'm opposed to use |
Fair enough, could always make a sendChatMessage, sendUserMessage ? Or always take a string, and convert to int when sending if it parses as one? |
@castaway changing function parameters type would be considered a breaking change, which means it would break all existing bots depends on this library. Although adding seperated implementation for each send message function would fix the issue we face, it also add unnecessary complexity to the project. It is indeed a tough decision to make. |
#99 has a better idea |
Describe the bug
Currently it only accept id(int), however according to the official docs, it needs to accept username(string) also
https://github.com/dart-lang/sdk/issues/4938
The text was updated successfully, but these errors were encountered: