Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor examples/todomvc.rs App component #1502

Closed
tigerros opened this issue Sep 27, 2023 · 3 comments
Closed

Refactor examples/todomvc.rs App component #1502

tigerros opened this issue Sep 27, 2023 · 3 comments
Labels
example Update examples good first issue Good for newcomers tweak Small changes to improve experience

Comments

@tigerros
Copy link

Specific Demand

The App component in examples/todomvc.rs is long, nested and hard to read. Since TodoMVC is a very popular way of showcasing a certain framework, the implementation should be clean and easy to read.
@tigerros tigerros changed the title Split examples/todomvc.rs App component Refactor examples/todomvc.rs App component Sep 27, 2023
@ealmloff ealmloff added example Update examples tweak Small changes to improve experience labels Sep 28, 2023
@ealmloff ealmloff added the good first issue Good for newcomers label Oct 18, 2023
@alexanderjophus
Copy link
Contributor

Can I take a look at this? Recently refactored my first dioxus site, would be good to get feedback/practice on the todomvc refactoring

@ealmloff
Copy link
Member

Can I take a look at this? Recently refactored my first dioxus site, would be good to get feedback/practice on the todomvc refactoring

That would be great!

@alexanderjophus alexanderjophus mentioned this issue Oct 19, 2023
Merged
@ealmloff
Copy link
Member

ealmloff commented Nov 4, 2023

Fixed by #1556

@ealmloff ealmloff closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
example Update examples good first issue Good for newcomers tweak Small changes to improve experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderjophus @ealmloff @tigerros