Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Props macro swallows any allowed rule from clippy #1623

Closed
1 of 4 tasks
marc2332 opened this issue Nov 8, 2023 · 1 comment
Closed
1 of 4 tasks

bug: Props macro swallows any allowed rule from clippy #1623

marc2332 opened this issue Nov 8, 2023 · 1 comment

Comments

@marc2332
Copy link
Contributor

marc2332 commented Nov 8, 2023

Problem

When a struct that derives the Props macro and is big enough for clippy to trigger the type_complexity warning will still throw the warning even if you bypass it with #[allow(clippy::type_complexity)]

Steps To Reproduce

Steps to reproduce the behavior:

  • Create a large struct enough to trigger the warning
  • Add #[derive(Props)
  • Add #[allow(clippy::type_complexity)]

Expected behavior

Don't throw the warning.

Screenshots

image

Environment:

  • Dioxus version: master
  • Rust version: 1.73
  • OS info: Windows 11
  • App platform: freya

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
  • I have no idea 😭
@tigerros tigerros mentioned this issue Nov 9, 2023
@tigerros
Copy link

tigerros commented Nov 9, 2023

Fixed in #1626

@ealmloff ealmloff closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants