Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test MaybeMath #158

Closed
Weibye opened this issue Jun 12, 2022 · 0 comments · Fixed by #162
Closed

Unit test MaybeMath #158

Weibye opened this issue Jun 12, 2022 · 0 comments · Fixed by #162
Assignees
@TimJentzsch
Labels
code quality Make the code cleaner or prettier. good first issue Good for newcomers

Comments

@Weibye
Copy link
Collaborator

Weibye commented Jun 12, 2022

What problem does this solve or what need does it fill?

MaybeMath has critical nuances that are important but hard to spot. It is vital for the layout calc that they are correctly behaving at all times.

What solution would you like?

Implement unit tests for the whole MaybeMath implementation so that we are confident it is working correctly

What alternative(s) have you considered?

Leave as is without testing
@Weibye Weibye added the enhancement New feature or request label Jun 12, 2022
@alice-i-cecile alice-i-cecile added good first issue Good for newcomers code quality Make the code cleaner or prettier. and removed enhancement New feature or request labels Jun 12, 2022
@alice-i-cecile alice-i-cecile mentioned this issue Jun 12, 2022
Merged
@TimJentzsch TimJentzsch self-assigned this Jun 12, 2022
@TimJentzsch TimJentzsch mentioned this issue Jun 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimJentzsch TimJentzsch

Labels
code quality Make the code cleaner or prettier. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests for MaybeMath TimJentzsch/taffy
3 participants
@alice-i-cecile @Weibye @TimJentzsch