Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of position and position_type properties doesn't match CSS spec #271

Closed
nicoburns opened this issue Nov 29, 2022 · 0 comments · Fixed by #295
Closed

Name of position and position_type properties doesn't match CSS spec #271

nicoburns opened this issue Nov 29, 2022 · 0 comments · Fixed by #295
Labels
breaking-change A change that breaks our public interface documentation Improvements or additions to documentation good first issue Good for newcomers usability Make the library more comfortable to use

Comments

@nicoburns
Copy link
Collaborator

nicoburns commented Nov 29, 2022

Problem

Context

I suspect inset hadn't yet been specified when Taffy/Stretch was first created.

Proposal

Rename position to inset and position_type to position to align with the CSS names for these properties.

@nicoburns nicoburns added documentation Improvements or additions to documentation usability Make the library more comfortable to use breaking-change A change that breaks our public interface labels Nov 29, 2022
@alice-i-cecile alice-i-cecile added the good first issue Good for newcomers label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change that breaks our public interface documentation Improvements or additions to documentation good first issue Good for newcomers usability Make the library more comfortable to use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants