Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taffy 0.3.18 crashes rustdoc build #644

Closed
mintlu8 opened this issue Apr 12, 2024 · 7 comments
Closed

Taffy 0.3.18 crashes rustdoc build #644

mintlu8 opened this issue Apr 12, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@mintlu8
Copy link

mintlu8 commented Apr 12, 2024

taffy version

0.3.18

Platform

Rustdoc

What you did

Compiling bevy_ui on rustdoc

What went wrong

taffy
@mintlu8 mintlu8 added the bug Something isn't working label Apr 12, 2024
@xangelix
Copy link

Builds on nightly seem broken with this.

@djeedai
Copy link

djeedai commented Apr 12, 2024

I'm on osx stable and same issue.

@djeedai
Copy link

djeedai commented Apr 12, 2024

I've tried 0.3.10 (min version for Bevy) to 0.3.18 and they all fail the same. But I don't see any other Bevy project compiling so it really looks like all those versions are broken?

@djeedai
Copy link

djeedai commented Apr 12, 2024

Duplicate of #642 ?

@nicoburns
Copy link
Collaborator

This is caused by rust-lang/rust#123824 For future reference, the following version exhibits the issue when compiling Taffy 0.3.18: rustc 1.79.0-nightly (a07f3eb43 2024-04-11)

@djeedai Are you sure you're seeing this on stable Rust. I am unable to reproduce this on rust 1.77.0 or 1.77.2 on macOS (but I am seeing the failure on

@nicoburns
Copy link
Collaborator

I've published Taffy 0.3.19 which fixes the internal failure within Taffy. Although 3rd-party callers of Taffy's APIs may need to update their calls.

@djeedai
Copy link

djeedai commented Apr 13, 2024

No this was in nightly my bad. The project I was trying had a forced nightly in a config file, and hadn't realized. This builds with stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants