When Stream() returns many lines, sometimes chunks of lines are not captured.

[DiscoRiver]

Intermittently, running stream to capture a reasonable amount of text sometimes misses chunks of lines.

You can see an example of this here in "Go Test": https://github.com/DiscoRiver/massh/runs/3832011162?check_suite_focus=true

I was using the command cat /var/log/auth.log in this test, and you'll see the following on line 48;

do: pam_unix(sudo:session): session opened for user root by (uid=0)

This should be something like what is on line 44;

Oct  7 20:45:48 fv-az224-778 sudo: pam_unix(sudo:session): session opened for user root by (uid=0)

There doesn't immediately seem to be a pattern, but more investigation is necessary into the concurrency model.

[DiscoRiver]

Confirmed that this does not happen with bulk return using massh.Config.Run()

[DiscoRiver]

Looks like I set the stream to work in chunks of 1024 bytes here, which unfortunately causes a few problems as we're no longer reading line-by-line.

Now I know the cause, I will investigate a more robust way of retaining data integrity on the output channels.

[DiscoRiver]

The function readToBytesChannel, which processes the Stdout and Stderr stream, has been updated to read lines for better granularity and lower complexity.

A wait group has also been added to ensure that all goroutines are returned elegantly. There was a problem with readToBytesChannel causing an issue further up the chain of execution, meaning each session was "completed" before all output had been processed.

Usage of this package should not be affected.