Skip to content
This repository has been archived by the owner on Apr 20, 2022. It is now read-only.

Error from TypeConverters not fire SlashCommandExecuted event #321

Closed
Misha12 opened this issue Nov 28, 2021 · 2 comments
Closed

Error from TypeConverters not fire SlashCommandExecuted event #321

Misha12 opened this issue Nov 28, 2021 · 2 comments
Labels
Bug Something isn't working Interaction Service Issues related to the interaction service

Comments

@Misha12
Copy link

Misha12 commented Nov 28, 2021

After execution of some slash command is fired event SlashCommandExecuted. But when execution fails in TypeConverter (TypeConverter returns TypeConverterResult.FromError(...)) result is provided only via result of ExecuteCommandAsync but not fired event. I think that is bug and problematic handle this situations.
@quinchs quinchs added Bug Something isn't working Interaction Service Issues related to the interaction service labels Nov 28, 2021
@Discord-Net-Labs Discord-Net-Labs deleted a comment from Liege72 Nov 28, 2021
@Cenngo
Copy link
Contributor

Cenngo commented Nov 28, 2021 •
edited
Loading

After execution of some slash command is fired event SlashCommandExecuted. But when execution fails in TypeConverter (TypeConverter returns TypeConverterResult.FromError(...)) result is provided only via result of ExecuteCommandAsync but not fired event. I think that is bug and problematic handle this situations.

This should be fixed on #314. Are you using the latest version?

@Misha12
Copy link
Author

Misha12 commented Nov 28, 2021

Sorry, my bad. I had 3.4.2. I updated to 3.4.6 and problem is fixed. Thanks

@Misha12 Misha12 closed this as completed Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working Interaction Service Issues related to the interaction service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Misha12 @quinchs @Cenngo