fix(ci): update pdm to 2.5.4 to fix requests and cachecontrol incompatibility #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onerandomusername
added
p: high
shiftinv
reviewed
May 5, 2023
shiftinv
added
t: meta
onerandomusername
changed the title
shiftinv
reviewed
May 5, 2023
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: arl <me@arielle.codes>
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: arl <me@arielle.codes>
shiftinv
changed the title
shiftinv
reviewed
May 6, 2023
There was a problem hiding this comment.
The whole cachecontrol/urllib3 situation certainly isn't great; pdm 2.5.4 technically sorta mostly works but got yanked, 2.5.5 is broken again.
In addition to that, the fact that pdm 2.5 now only locks selected groups makes things really annoying to work with when you're dealing with multiple nox venvs.
I understand why it does that, and I don't like it.
Long story short, both urllib3 2.0 and pdm 2.5 break things, so the best course of action to at least get CI unblocked for now would be to stay on pdm 2.4, and force urllib3 to 1.x:
shiftinv@57dd741
8 tasks
|
As discussed in DMs this isn't worth the trouble for now - #1026 supersedes this PR c: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pdm-project/pdm#1886
psf/cachecontrol#294
changelog: https://pdm.fming.dev/2.5/dev/changelog/#release-v254-2023-05-05
this also fixes ci https://github.com/DisnakeDev/disnake/actions/runs/4891445480
Checklist
pdm lintpdm pyright