Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palette expansion onto parts #27

Open
zaventh opened this issue Dec 23, 2023 · 4 comments
Open

Palette expansion onto parts #27

zaventh opened this issue Dec 23, 2023 · 4 comments

Comments

@zaventh
Copy link
Contributor

zaventh commented Dec 23, 2023

I am attempting to extend tk-viewer to display every palette of each part. What I am seeing is that the palette data does kind of work, however it seems a bit off. Some of the RGB data appears duplicated and the colours themselves appear a bit off.

Screenshot from 2023-12-22 17-24-13

I will be debugging further but I was wondering if you've run into this or if this is some kind of known issue. I did build tk-partpicker as well but that seems to exhibit similar problems and/or doesn't really work in general.

@DizzyThermal
Copy link
Owner

Every palette isn't unique, there are definitely repetitive palette colors, but what your doing seems like what I've seen when scrubbing the paletteIndex from 0 to the max number of palettes.. I believe NTK cherry picks palettes that look good as "dyes" in the game. I believe only a fraction of palettes are actually used / look good.

@zaventh
Copy link
Contributor Author

zaventh commented Dec 27, 2023

Thanks. That makes sense. I thought originally some colours were even missing but I think not. The must also be applying some kind of mask on some of the palettes I think in the game to achieve like an inverted look.

@zaventh zaventh closed this as completed Dec 27, 2023
@DizzyThermal
Copy link
Owner

@zaventh - I think you may be right - as far as some colors missing.. Either that or there's some hue-shifting/shading as part of the EPF and/or PAL that isn't being taken into consideration.

I've tried taking a very simple example - Merchant Armor.. I can't seem to find that shade of Green.. I've tried using various PALs as well:

char.dat:Body.pal
char.dat:Coat.pal
char.dat:ITEM.PAL
misc.dat:ITEM.PAL

No avail.. More research to do I suppose!

@DizzyThermal
Copy link
Owner

@zaventh - https://github.com/DizzyThermal/EPFViewer

I'd like to make more tooling in Godot 4.x as I feel I can develop faster than in Java/Swing - my TK reversing efforts will be focused there 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants